Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libvpd - C++ library for system vpd access https://bugzilla.redhat.com/show_bug.cgi?id=307891 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-10-10 21:55 EST ------- NEEDSWORK 1. BuildRequires: db43++-devel A package of this name doesn't exist in Fedora. Are you referring to db4-devel (which at least under FC7 contains libdb_cxx - FC8 applies a different package split)? 2. /bin/sh configure --prefix=%{_prefix}/ This way of invoking configure causes your package not to receive all required settings. Better use %configure, instead. 3. %files ... /usr/lib a) Normal packages must not own /usr/lib. They may only own files and directories below it. b) Your package ships libraries, but invokes configure improperly. If it did, these libraries would land in %{_libdir} (i.e. /usr/lib64 on x86_64), i.e. you should be using %{_libdir}/* instead. 4. Package ships static libs. The Fedora Packaging Guideline strongly discourage packager from doing so (append --disable-static to %configure). Should you nevertheless, feel not to be able to avoid shipping them, please move these static libs to a separate subpackage (*-static) 5. Package ships libtool archives. Shipping these is being frowned upon on Fedora. Please remove them. (In %install add something similar to rm %{_libdir}/*.la or add %exclude %{_libdir}/*.la to %files) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review