https://bugzilla.redhat.com/show_bug.cgi?id=1789919 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use the source from the official website, not from "wdune", you can't just copy source tike that. Ask upstream to publish the source for 4.0.0 on their Sourceforge. Alternatively generate the source from the GIT repo but don't put on your server, instead just put the tar.gz as source: but add comment explaining how you generated the tar.gz I would recommend: # git clone https://git.code.sf.net/p/freewrl/git freewrl # cd freewrl/freex3d/ # git archive --format tar.gz --prefix freewrl-4.0.0/ 36b721ca374d695c10af8137c943f27f12503014 > freewrl-4.0.0.tar.gz Source: freewrl-4.0.0.tar.gz - Missing dist tag: Release: 1%{?dist} - Why? This is surely not needed as build time: BuildRequires: bitstream-vera-sans-fonts - This should be a Requires, not a BuildRequires: Requires: desktop-file-utils - Why does it Requires Firefoy?? Requires: firefox - No: %global debug_package %{nil} You need to find why it's not working as expected. Mostly because you installed the library as 0644 instead of 0755: it needs to be executable to be stripped: install -m 0755 -p ../freewrl-git/freex3d/src/lib/.libs/libFreeWRL.so.4.1.0 $RPM_BUILD_ROOT/%{_libexecdir}/libFreeWRL.so.4.1.0 Same, remove that junk: echo > debugsourcefiles.list echo >> debugsourcefiles.list /usr/lib/rpm/find-debuginfo.sh - Are you sure there isn't a make install script? Yes there is. - No: install -m 644 -p ../freewrl-git/freex3d/COPYING $RPM_BUILD_ROOT/%{_datadir}/freewrl install -m 644 -p ../freewrl-git/freex3d/COPYING.LESSER $RPM_BUILD_ROOT/%{_datadir}/freewrl Don't install these licenses in datadir. Instead include them with %license in %files. %license COPYING COPYING.LESSER - Glob the extension for man pages as the compression may change in the future: %{_mandir}/man1/freewrl.1.* - Fix your changelog entry: * Fri Jan 10 2020 J Scheurich <mufti11@xxxxxx> - 4.0-1 - Initial packaging - the library should not go to libexecdir but libdir - Add docs: %doc AUTHORS ChangeLog NEWS README TODO xAI-DESIGN.README Reworked SPEC to work with more stuff (OpenCL, OpenGL), there are two bugs related to OpenCL that should be fixed upstream but I'm not touching Sourceforge with a ten foot pole. ====================================================================================================================== Name: freewrl Summary: X3D/VRML open source viewer Version: 4.0 Release: 1%{?dist} License: GPLv3+ URL: http://freewrl.sourceforge.net/ # git clone https://git.code.sf.net/p/freewrl/git freewrl # cd freewrl/freex3d/ # git archive --format tar.gz --prefix freewrl-4.0/ 36b721ca374d695c10af8137c943f27f12503014 > freewrl-4.0.tar.gz Source: freewrl-4.0.tar.gz BuildRequires: gcc-g++ BuildRequires: autoconf BuildRequires: automake BuildRequires: libtool BuildRequires: pkgconfig(fontconfig) BuildRequires: pkgconfig(freealut) BuildRequires: pkgconfig(freetype2) BuildRequires: pkgconfig(gl) BuildRequires: pkgconfig(glu) BuildRequires: pkgconfig(imlib2) BuildRequires: pkgconfig(libcurl) BuildRequires: pkgconfig(libjpeg) BuildRequires: pkgconfig(liblo) BuildRequires: pkgconfig(libpng) BuildRequires: pkgconfig(libxml-2.0) BuildRequires: pkgconfig(ode) BuildRequires: pkgconfig(openal) BuildRequires: pkgconfig(OpenCL) BuildRequires: pkgconfig(x11) BuildRequires: pkgconfig(xaw7) BuildRequires: pkgconfig(xmu) BuildRequires: pkgconfig(xproto) BuildRequires: pkgconfig(xt) BuildRequires: pkgconfig(xxf86vm) BuildRequires: pkgconfig(zlib) Requires: %{name}-libs = %{version}-%{release} Requires: desktop-file-utils Recommends: bitstream-vera-sans-fonts Recommends: firefox Recommends: ImageMagick Recommends: sox Recommends: wget %description FreeWRL is an X3D/VRML open source viewer for Windows, Linux, OSX and Android. %package libs Summary: FreeWRL library %description libs Library files for FreeWRL. %package devel Summary: FreeWRL development files Requires: %{name}-libs%{?_isa} = %{version}-%{release} %description devel Development files for FreeWRL. %prep %autosetup # Typo in OpenCL code sed -i "s|#if (defined(_MSC_VER)|#if (defined(_MSC_VER))|" src/lib/opencl/OpenCL_Utils.h # Bug in OpenCL code sed -i "s|float awidth = (float) tg->Bindable.naviinfo.width;|struct sNaviInfo *naviinfo;\n naviinfo = (struct sNaviInfo *)tg->Bindable.naviinfo;\n float awidth = (float) naviinfo->width;|" src/lib/scenegraph/Collision.c %build autoreconf -fiv %configure --enable-rbp --with-OpenCL=yes %make_build %install %make_install rm -f %{buildroot}%{_libdir}/*.{a,la} %files %doc AUTHORS ChangeLog NEWS README TODO xAI-DESIGN.README %license COPYING COPYING.LESSER %{_bindir}/freewrl %{_bindir}/freewrl_msg %{_datadir}/applications/freewrl.desktop %{_datadir}/pixmaps/freewrl.png %{_mandir}/man1/freewrl.1.* %files libs %{_libdir}/libFreeWRL.so.4* %files devel %{_includedir}/libFreeWRL.h %{_libdir}/libFreeWRL.so %{_libdir}/pkgconfig/libFreeWRL.pc %changelog * Fri Jan 10 2020 J Scheurich <mufti11@xxxxxx> - 4.0-1 - Initial packaging ================================================================================================================= -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
