https://bugzilla.redhat.com/show_bug.cgi?id=1788893 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #8 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - This line is not necessary as it is automatically added by Go packaging: BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. (In reply to Jakub Jelen from comment #4) > > With these changes, the copr builds go fine: > > https://copr.fedorainfracloud.org/coprs/jjelen/yubihsm-shell/builds/ > > But only if I allow internet access during build. Otherwise it fails with > the following during "go generate". Do you have any tips for this issue from > top of your head (I am sorry for stealing a topic a bit): > > + go generate > go: github.com/google/gousb@v0.0.0-20190812193832-18f4c1d8a750: invalid > version: git fetch -f origin refs/heads/*:refs/heads/* > refs/tags/*:refs/tags/* in > /builddir/go/pkg/mod/cache/vcs/ > cc39ad3e0b2f5cf4389fa4743b421f443f8cb8378b0937fa336ad02ef8683e17: exit > status 128: > fatal: unable to access 'https://github.com/google/gousb/': Could not > resolve host: github.com yubihsm-connector use the new Go modules to build/vendor stuff, we are not yet compatible with modules in Fedora so we disable them. However when running go generate, it will try to download the modules from the Internet. Try disabling go modules before running Go generate: export GO111MODULE=off -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
