https://bugzilla.redhat.com/show_bug.cgi?id=1788893 --- Comment #4 from Jakub Jelen <jjelen@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > .20200108git18f4c1d8 is not needed in Release, it is computed automatically > in dist macro. Right. I already figured this out, but did not update the spec file. Will update. > - Not needed, this is automatically added: > > BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} > BuildRequires: go-rpm-macros Right. I figured this out too, but I forgot to remove it. > - You're missing the license and docs: > > %global common_description %{expand: > The gousb package is an attempt at wrapping the libusb library into a > Go-like binding.} > > %gometa > > %global golicenses LICENSE > %global godocs AUTHORS CONTRIBUTING.md README.md Thanks. I added that. > - You need a Requires for pkgconfig(libusb) of the devel package > > %global godevelheader %{expand: > Requires: pkgconfig(libusb)} Thank you very much. The updated spec file and srpm are here: Spec URL: https://jjelen.fedorapeople.org/golang-github-google-gousb.spec SRPM URL: https://jjelen.fedorapeople.org/golang-github-google-gousb-0-0.1.20200108git18f4c1d.fc32.src.rpm Also checking the old go usb package that I did last year golang-github-thorduri-libusb, it is still not needed for anything else than yubihsm-connector so I guess I can retire it in the next release and mark this package as Obsoletes: golang-github-thorduri-libusb < 0-0.4 What do you think? With these changes, the copr builds go fine: https://copr.fedorainfracloud.org/coprs/jjelen/yubihsm-shell/builds/ But only if I allow internet access during build. Otherwise it fails with the following during "go generate". Do you have any tips for this issue from top of your head (I am sorry for stealing a topic a bit): + go generate go: github.com/google/gousb@v0.0.0-20190812193832-18f4c1d8a750: invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /builddir/go/pkg/mod/cache/vcs/cc39ad3e0b2f5cf4389fa4743b421f443f8cb8378b0937fa336ad02ef8683e17: exit status 128: fatal: unable to access 'https://github.com/google/gousb/': Could not resolve host: github.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
