https://bugzilla.redhat.com/show_bug.cgi?id=1770566 Lars Kiesow <lkiesow@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lkiesow@xxxxxx Flags|needinfo?(lkiesow@xxxxxx) | --- Comment #7 from Lars Kiesow <lkiesow@xxxxxx> --- Thanks for the helpful feedback and especially thanks for pointing me to go2rpm. That tool is really helpful and makes packaging go projects so much easier. I've updated the specs and hopefully fixed all issues pointed out including the rpmlint notices except for the warning about the term `greppable` which is correct here as a technical term. I've named the main package gron as suggested in the Golang Packaging Guidelines with the devel package containing the full go path, running with the same reasoning as the guideline [1]: > Source packages that provide a well-known application such as etcd MUST be named after the application. End users do not care about the language their applications are written in. While you could argue how well-known gron is, users will definitely expect the name gron. Hence I did take a look at the etcd packaging and followed their lead in addition to the examples [2] from the guide. New Spec URL: https://data.lkiesow.dev/rpm/gron/0.6.0-2/gron.spec New SRPM URL: https://data.lkiesow.dev/rpm/gron/0.6.0-2/gron-0.6.0-2.fc31.src.rpm New Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40083094 Please let me know if anything else is missing. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_source_packages_src_rpm [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang_templates/#_minimal_binary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
