https://bugzilla.redhat.com/show_bug.cgi?id=1787578 Jared Smith <jsmith.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- Package is approved. Package is approved Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Expat License", "Expat License", "GPL (v2)". 133 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1787578-vokoscreenNG/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/vokoscreenNG(Failed, set, locale,, to, defaulting, C), /usr/share/licenses/vokoscreenNG(Failed, set, locale,, to, defaulting, C) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vokoscreenNG-3.0.0-1.fc32.x86_64.rpm vokoscreenNG-debuginfo-3.0.0-1.fc32.x86_64.rpm vokoscreenNG-debugsource-3.0.0-1.fc32.x86_64.rpm vokoscreenNG-3.0.0-1.fc32.src.rpm vokoscreenNG.x86_64: W: spelling-error Summary(en_US) screencaster -> screen caster, screen-caster, screenwriter vokoscreenNG.x86_64: W: spelling-error %description -l en_US screencaster -> screen caster, screen-caster, screenwriter vokoscreenNG.x86_64: W: no-manual-page-for-binary vokoscreenNG vokoscreenNG.x86_64: W: install-file-in-docs /usr/share/doc/vokoscreenNG/INSTALL vokoscreenNG.src: W: spelling-error Summary(en_US) screencaster -> screen caster, screen-caster, screenwriter vokoscreenNG.src: W: spelling-error %description -l en_US screencaster -> screen caster, screen-caster, screenwriter 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: vokoscreenNG-debuginfo-3.0.0-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). vokoscreenNG.x86_64: W: spelling-error Summary(en_US) screencaster -> screen caster, screen-caster, screenwriter vokoscreenNG.x86_64: W: spelling-error %description -l en_US screencaster -> screen caster, screen-caster, screenwriter vokoscreenNG.x86_64: W: invalid-url URL: https://github.com/vkohaupt/vokoscreenNG <urlopen error [Errno -2] Name or service not known> vokoscreenNG.x86_64: W: no-manual-page-for-binary vokoscreenNG vokoscreenNG.x86_64: W: install-file-in-docs /usr/share/doc/vokoscreenNG/INSTALL vokoscreenNG-debugsource.x86_64: W: invalid-url URL: https://github.com/vkohaupt/vokoscreenNG <urlopen error [Errno -2] Name or service not known> vokoscreenNG-debuginfo.x86_64: W: invalid-url URL: https://github.com/vkohaupt/vokoscreenNG <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://github.com/vkohaupt/vokoscreenNG/archive/3.0.0/vokoscreenNG-3.0.0.tar.gz : CHECKSUM(SHA256) this package : fdfa0a0e8a89247a1ac13fe4f4bb873e21167a3a9776a94ea665fdf20e783fe7 CHECKSUM(SHA256) upstream package : fdfa0a0e8a89247a1ac13fe4f4bb873e21167a3a9776a94ea665fdf20e783fe7 Requires -------- vokoscreenNG (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.13)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) vokoscreenNG-debuginfo (rpmlib, GLIBC filtered): vokoscreenNG-debugsource (rpmlib, GLIBC filtered): Provides -------- vokoscreenNG: application() application(vokoscreenNG.desktop) vokoscreenNG vokoscreenNG(x86-64) vokoscreenNG-debuginfo: debuginfo(build-id) vokoscreenNG-debuginfo vokoscreenNG-debuginfo(x86-64) vokoscreenNG-debugsource: vokoscreenNG-debugsource vokoscreenNG-debugsource(x86-64) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1787578 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Perl, Ocaml, Java, R, fonts, Python, SugarActivity, Haskell, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
