[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Artem <ego.cordatus@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #10 from Artem <ego.cordatus@xxxxxxxxx> ---
Few minor issues:

1. '%{_mandir}/man.6/' is incorrect place. Should been '%{_mandir}/man6/'

install -Dp -m 0644 man/DDNet.6 %{buildroot}%{_mandir}/man6/DDNet.6
install -Dp -m 0644 man/DDNet-Server.6
%{buildroot}%{_mandir}/man6/DDNet-Server.6


2. BSD license not needed anymore since you unbundled 'json-parser'. You need
to remove it from License tag and from breakdown license explanation section.

Please fix this before import. Otherwise LGTM.


Rpmlint
-------
Checking: ddnet-12.8.1-6.fc32.x86_64.rpm
          ddnet-data-12.8.1-6.fc32.noarch.rpm
          ddnet-server-12.8.1-6.fc32.x86_64.rpm
          ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
          ddnet-debugsource-12.8.1-6.fc32.x86_64.rpm
          ddnet-12.8.1-6.fc32.src.rpm
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.src: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet.src:95: W: unversioned-explicit-provides
bundled(dejavu-sans-cjkname-fonts)
ddnet.src:96: W: unversioned-explicit-provides
bundled(dejavu-wenquanyi-micro-hei-fonts)
6 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: ddnet-server-debuginfo-12.8.1-6.fc32.x86_64.rpm
          ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "ru_UA.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "ru_UA.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
6 packages and 0 specfiles checked; 0 errors, 3 warnings.



Source checksums
----------------
https://github.com/ddnet/ddnet/archive/12.8.1/ddnet-12.8.1.tar.gz :
  CHECKSUM(SHA256) this package     :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4
  CHECKSUM(SHA256) upstream package :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4


Requires
--------
ddnet (rpmlib, GLIBC filtered):
    ddnet-data
    libGL.so.1()(64bit)
    libGLEW.so.2.1()(64bit)
    libGLU.so.1()(64bit)
    libSDL2-2.0.so.0()(64bit)
    libX11.so.6()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.1.1()(64bit)
    libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
    libcurl.so.4()(64bit)
    libfreetype.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libjsonparser.so.1.1()(64bit)
    libm.so.6()(64bit)
    libopusfile.so.0()(64bit)
    libpnglite.so.0()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libwavpack.so.1()(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    rtld(GNU_HASH)

ddnet-data (rpmlib, GLIBC filtered):
    ddnet
    hicolor-icon-theme

ddnet-server (rpmlib, GLIBC filtered):
    ddnet(x86-64)
    libc.so.6()(64bit)
    libcrypto.so.1.1()(64bit)
    libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libjsonparser.so.1.1()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    rtld(GNU_HASH)

ddnet-debuginfo (rpmlib, GLIBC filtered):

ddnet-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ddnet:
    application()
    application(ddnet.desktop)
    bundled(dejavu-sans-cjkname-fonts)
    bundled(dejavu-wenquanyi-micro-hei-fonts)
    ddnet
    ddnet(x86-64)
    metainfo()
    metainfo(ddnet.appdata.xml)
    mimehandler(x-scheme-handler/ddnet)

ddnet-data:
    ddnet-data

ddnet-server:
    ddnet-server
    ddnet-server(x86-64)

ddnet-debuginfo:
    ddnet-debuginfo
    ddnet-debuginfo(x86-64)
    debuginfo(build-id)

ddnet-debugsource:
    ddnet-debugsource
    ddnet-debugsource(x86-64)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux