https://bugzilla.redhat.com/show_bug.cgi?id=1786918 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Dan Horák <dan@xxxxxxxx> --- few rather cosmetic issues - s/Source:/Source0:/ - you can use %{make_build} and %{make_install} instead of make + parameters in %build and %install - consider using %{name} in Source and %files instead of repeating "restmbmaster" - $RPM_BUILD_ROOT is being obsoleted, %{buildroot} is the modern equivalent - drop the %config/%attr options for the unit file, the system unit file is not a config file and the set attributes are the default ones anyway - you might want to include /etc/restmbmaster/ directory in the package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
