https://bugzilla.redhat.com/show_bug.cgi?id=1786207 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > shortcommit uses first seven chars from the commit and gitrev variable uses the last eight The first seven (or eight) is appropriate. That snippet is supposed to uniquely identify the commit. So what matters is what git accepts. And git accepts any prefix of the sha1 hash, as long as it is unique. Something like 7 or 8 characters is usually unique, and 7 was the default abbreviation in git for a long time iirc. + package name is OK + latest version (recent git snapshot) + license is acceptable for Fedora (BSD) + license is specified correctly + builds and installs OK + BR/R/P look OK rpmlint has only bogus hints. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
