https://bugzilla.redhat.com/show_bug.cgi?id=1780849 Sergio Monteiro Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- I'd would propose all patches be -p1 instead -p0 [1] and use %py3_build and %py3_install [2]. Also I'd remove "%define __brp_python_bytecompile %{nil}" with next patch in attachment . Other questions raised on my previous comment one are replied (bug in other place) and Development files must be in a -devel package , for now we can keep it on main package. Package APPROVED ! Please add me as maintainer and I could do the changes myself [1] %autosetup -n pymol-open-source-%{version} -p1 [2] %build %py3_build -- --use-msgpackc=c++11 --glut %install %py3_install -- --use-msgpackc=c++11 --glut --pymol-path=%{python3_sitearch}/pymol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
