https://bugzilla.redhat.com/show_bug.cgi?id=1786724 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - SPEC name and package name (and bug report name) must be the same - Fix that summary: Summary: Example python module - Since it's a binary, i'd argue you should just have a main package called: git-up - Requires are now autodetected, only keep on EPEL7 Requires: python3-six Requires: python3-colorama Requires: python3-click Requires: python3-termcolor Requires: python3-GitPython - Source is 404: Getting https://files.pythonhosted.org/packages/source/P/PyGitUp/PyGitUp-1.6.1.tar.gz to ./PyGitUp-1.6.1.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Source should be: Source0: %{pypi_source git-up} - Directory is not good either: + cd PyGitUp-1.6.1 /var/tmp/rpm-tmp.Ovv3Ou: line 39: cd: PyGitUp-1.6.1: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.Ovv3Ou (%prep) - Run tests: BuildRequires: python3dist(click) BuildRequires: python3dist(colorama) BuildRequires: python3dist(gitpython) BuildRequires: python3dist(nose) BuildRequires: python3dist(six) BuildRequires: python3dist(termcolor) BuildRequires: git-core […] %check git config --global user.email "koji@xxxxxxxxxxxxxxxxx" git config --global user.name "Koji Build System" PYTHONPATH=%{buildroot}%{python3_sitelib} nosetests-%{python3_version} - LICENSE file is not provided by Pypi: error: File not found: /builddir/build/BUILDROOT/git-up-1.6.1-1.fc32.x86_64/usr/share/licenses/git-up/LICENCE Please ask upstream to include it or use the Github archive instead, or download it as a Source1 and install it manually. %global srcname git-up Name: git-up Version: 1.6.1 Release: 1%{?dist} Summary: Example python module License: MIT URL: https://pypi.python.org/pypi/git-up Source0: %{pypi_source} Source1: https://raw.githubusercontent.com/msiemens/PyGitUp/master/LICENCE BuildArch: noarch BuildRequires: python3-devel BuildRequires: python3dist(click) BuildRequires: python3dist(colorama) BuildRequires: python3dist(gitpython) BuildRequires: python3dist(nose) BuildRequires: python3dist(six) BuildRequires: python3dist(termcolor) BuildRequires: git-core %global _description %{expand: Provides a more convenient git pull.} %description %_description %prep %autosetup -n %{srcname}-%{version} cp %{S:1} . %build %py3_build %install %py3_install %check git config --global user.email "koji@xxxxxxxxxxxxxxxxx" git config --global user.name "Koji Build System" PYTHONPATH=%{buildroot}%{python3_sitelib} nosetests-%{python3_version} %files %license LICENSE %doc README.rst %{python3_sitelib}/git_up-*.egg-info/ %{python3_sitelib}/PyGitUp/ %{_bindir}/git-up %changelog * Fri Dec 20 2019 Martin Jackson <mhjacks@xxxxxxxxxx> - 1.6.1-1 - Initial release -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
