https://bugzilla.redhat.com/show_bug.cgi?id=1786207 --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- http://aiozmq.readthedocs.org → https:// In general it is nicer to download the tarball directly from github (easier upgrades): %global commit 4e6703c7c56e07c58898228f5d4cf5cb56065a26 %{?commit:%global shortcommit %(c=%{commit}; echo ${c:0:7})} Source0: https://github.com/aio-libs/aiozmq/archive/%{commit}/%{name}-%{shortcommit}.tar.gz ... %prep %autosetup %{?commit:-n %{name}-%{commit}} %{python3_sitelib}/%{pypi_name}, %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info → add trailing slash Looks good, but FTI: - nothing provides python3.8dist(pyzmq) < 17.1.2 needed by python3-aiozmq-0.8.0-2.20191223git56065a26.fc32.noarch The requirements specified in the sources are inconsistent, so maybe it does work with newer versions after all: aiozmq-0.8.0/requirements.txt: pyzmq>=14.2.0 aiozmq-0.8.0/setup.py: install_requires = ['pyzmq>=13.1,<17.1.2'] It would be useful to run the tests. If the test line is uncommented, it just says that the command is deprecated and does not run any tests. Using pytest seems to work fine, except that one test fails with "SocketOperation on a closed socket" or something like that. I'll attach a diff that makes the tests and installation pass for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
