[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1785968

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
"version- control system" — space after "-" should be removed.

%description is repeated, defining it once as a macro using %{expand:} would 
be nice.

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/__pycache__/*
is repeated. It would be better to not use a glob, but something like
%{python3_sitelib}/__pycache__/%{pypi_name}.*.py*

%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info – add "/" a the end
if this is a directory.

+ package name is OK
+ license is acceptable for Fedora (public domain)
+ license is specified correctly
  → please use "Public Domain" (capitalized), as in
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List.

+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux