https://bugzilla.redhat.com/show_bug.cgi?id=1785970 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends On| |1785983, 1785967 Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- %description is repeated, defining it once as a macro using %{expand:} would be nice. CHANGELOG.md can be added to %doc. + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + fedora-review and rmplint seem happy - R/P/BR look OK, but some packages are not installable: - nothing provides python3dist(aiozmq) needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch - nothing provides python3.8dist(apply-defaults) < 1 needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch - nothing provides python3dist(apply-defaults) < 1 needed by python3-jsonrpcserver-4.0.5-1.fc32.noarch I assume apply-default will be solved by #1785967, but aiozmq seems a problem as you said in your mail. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785967 [Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params https://bugzilla.redhat.com/show_bug.cgi?id=1785983 [Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for Flask applications -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
