https://bugzilla.redhat.com/show_bug.cgi?id=1785977 --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- The package name is repeated in summary unnecessarily in summary. %description is repeated. I'd suggest the standard trick with %expand: %global _description %{expand: Helping users and developers to get information about the environment to report bugs or even test your system without spending a day on it. It can get information about hardware, OS, paths, Python distribution and packages, including Qt-things.} %description %_description %description -n python3-%{pypi_name} %_description > # install license file > mkdir -p %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}/ > cp -pr %{SOURCE1} %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name} It should suffice to do > %prep > cp ${SOURCE1} . But looking at the upstream repo, it already includes a license. Why not use that file? If it is not included in the pypi tarball, then provide a full URL to it: Source1: https://gitlab.com/dpizetta/helpdev/raw/master/LICENSE.rst Anyway, package looks good. + name is OK + license is acceptable (MIT) + license is specified correctly (upstream talks about CC-BY-4.0 for images, but there are no images in the binary package, so this doesn't apply). + builds OK + P/BR look OK Unfortunately the package does not install: - nothing provides python3dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch - nothing provides python3.8dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
