https://bugzilla.redhat.com/show_bug.cgi?id=1784420 --- Comment #6 from Robert Fairley <rfairley@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > - You need to add a comment above the patch explaining the changes you've > done. > Added a comment in the specfile, and also uploaded a diff (sorry, did not upload the diff before): https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/coreos-installer-fix-metadata.diff > - I don't think that is necessary: > > Obsoletes: coreos-installer < 0.0.1 > Removed this - makes sense. Added a comment noting why this is removed. > - You probably need a Provides along the coreos-installer-dracut Obsoletes > > Provides: coreos-installer-dracut = %{version}-%{release} > Since the dracut modules will not be included in this package, and will soon be replaced by https://github.com/coreos/coreos-installer/pull/100, I've left the `Provides` out. The `Obsoletes` should be sufficient here. I also updated the specfile for the 0.1.1 version - released recently. Updated specfile and SRPM: Spec URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer-0.1.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
