https://bugzilla.redhat.com/show_bug.cgi?id=1785391 --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Felix Schwarz from comment #1) > just some random bikeshedding :-) > > > Source0: https://pypi.python.org/packages/source/s/spec/spec-%{version}.tar.gz > > How about %pypi_source here? (%global srcname spec) OK, done in -2. > Also: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_the_python_provide_macro OK, done in -2. > > Requires: python3-nose >= 1.3 > > Requires: python3-six > > This might be picked up automatically in F30+ Indeed they are; EL-8 too. > > %setup -q -n spec-%{version} > > you may want to use: > %autosetup -n %{srcname}-%{version} I prefer not to use %autosetup because I prefer to comment on patches as they are applied rather than when they are declared. > > %{python3_sitelib}/spec-%{version}-py?.?.egg-info/ > > This will break once we have Python 3.10. Packaging guide suggests: > %{python3_sitelib}/%{srcname}-*.egg-info/ Fixed in -2. (In reply to Felix Schwarz from comment #2) > Consider enabling source file verification: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_source_file_verification > You can use "%{pypi_source}.asc" to download the GPG signature. Done in -2. Spec URL: http://subversion.city-fan.org/repos/cfo-repo/python-spec/branches/fedora/python-spec.spec SRPM URL: http://www.city-fan.org/~paul/extras/python-spec/python-spec-1.4.1-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
