[Bug 1784590] Review Request: quarter - Lightweight glue library between Coin and Qt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1784590



--- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #2)
>  - The doc should be noarch
> 
> %package doc
> Summary:        Development documentation for %{name}
> Requires:       %{name}-devel% = %{version}-%{release}
> BuildArch:      noarch

Whoops! Good catch.


>  - In order to avoid unannounced SONAME bump, we encourage not globbing the
> major SONAME version, be more specific instead.
> 
> %{_libdir}/*.so.1*
> %{_libdir}/*.so.20

I went a slightly different route with the soversion and added a global macro
variable at the top of the spec file

%{_libdir}/*.so.1*
%{_libdir}/*.so.%{sover}

Spec URL: https://hobbes1069.fedorapeople.org/quarter.spec
SRPM URL: https://hobbes1069.fedorapeople.org/quarter-1.0.1-2.fc31.src.rpm

* Thu Dec 19 2019 Richard Shaw <hobbes1069@xxxxxxxxx> - 1.0.1-2
- Update per reviewer feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux