https://bugzilla.redhat.com/show_bug.cgi?id=1784553 --- Comment #3 from Mat Booth <mat.booth@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > There are some small issues. Once those are fixed and/or clarified, the > package looks good to go. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > > Please provide short reasons for the inclusion of both patches in the .spec > file (though really, "port to servlet 3.1" is almost descriptive enough > already). > Comments added. > - Please specify the license breakdown: > > which parts are CDDL-1.0 / GPLv2 w/ classpath exception, > and which are ASL 2.0 > Classes in the org.apache.jasper package are apache licensed. Comment added to the spec file. > - rpmlint complains about a dangling symlink (looks like it's either missing > a > / in the middle, or something else has gone wrong): > > > /usr/share/java/javax.servlet.jsp/glassfish-jsp-apijavax.servlet.jsp-api.jar > ^^ issue here? > Nope this symlink is actually valid and is satisfied by files installed by the generated requirement on the glassfish-jsp-api package. This is a known limitation of rpmlint. > - [?]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > In my experience, most Java projects don't include the ASL 2.0 license > text ... > do you know why? > > Yes, many projects use a maven resources plugin to inject licenses into the jar at build-time to avoid duplication. This is not an upstream mistake, but because of the terms of the Apache license, Fedora requires us to "Include a copy .... as part of the Fedora package in %license" New spec file with added comments: Spec URL: https://fedorapeople.org/~mbooth/reviews/glassfish-jsp.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/glassfish-jsp-2.3.4-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
