https://bugzilla.redhat.com/show_bug.cgi?id=1784230 --- Comment #4 from Carson Black <uhhadd@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #3) > - GPL-2.0-or-later is not a valid license shorthand in Fedora, see list > here: > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses > > License: GPLv2+ > > - Typo in Source0: missing a % before {version} > > Source0: > https://invent.kde.org/kde/ikona/-/archive/v%{version}/%{name}-%{version}. > tar.gz > > - Changelog entries are not correctly formatted: > > * Thu Dec 12 2019 Carson Black <uhhadd@xxxxxxxxx> - 0.7.1-1 > > i.e. add the day of the week before the month, no v before the version, and > the Release info after the version. > > - > > BuildRequires: gcc-g++ → BuildRequires: gcc-c++ > > -snip - Alright, revised the package based on your feedback. Spec URL: https://gist.githubusercontent.com/Appadeia/44ca0f5ff75a3a897d0b74126213d6f5/raw/b7a3bc03f3f7565cbb627237c3241a9223afb614/ikona.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1358/39701358/ikona-0.7.1-1.fc31.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39701356 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
