https://bugzilla.redhat.com/show_bug.cgi?id=1784501 --- Comment #4 from Mat Booth <mat.booth@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > 1. The URL redirects to https://github.com/takari/polyglot-maven, which is > also the prefix for Source0. Use that value for URL too. > You could then even replace the Source0 prefix with %{url}. I never noticed that, fixed. > > 2. Obsoletes and Provides look correct, except shouldn't the obsoleted EVR > be "0.4.4-2" instead of "0.4.4-1", matching the "first EVR" of the renamed > package? Fixed. > > 3. I assume you know what you're doing with the XPath modifications that are > present. Ah, yeah -- all this fussing about is to avoid needing to ressurect the takari-* stack of packages. Trust me I'm a doctor [0] [0] Not actually a real doctor! > > 4. License tag is correct, according to licensecheck. > > 5. Tests run and pass. > > 6. BR on mvn(org.apache.maven:maven-parent:pom:) seems to be superfluous, > xmvn-builddep does not list it. > It is definitely needed, or you get this error: "Non-resolvable parent POM for org.apache.maven:maven:3.6.1: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven:maven-parent:pom:33 has not been downloaded from it before. @ org.apache.maven:maven:3.6.1, /usr/share/maven-poms/maven/maven.pom, line 22, column 11 -> [Help 2]" I believe this is a shortcoming of xmvn-builddep. > 7. I'm not sure the LICENSE file is installed for every combination of > subpackages. > Additionally including in the -common subpackage should take care that, I > think (but I didn't check every subpackage interdependency). Good thought, fixed. Spec URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot-0.4.4-3.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
