https://bugzilla.redhat.com/show_bug.cgi?id=1763457 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1783615 | |(rust-compiletest_rs) --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Jerry James from comment #4) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Make the bug summary match the spec file Summary field. > Done > - Only the rust-nickel-devel and rust-nickel+default-devel packages can be > installed. The other two (rust-nickel+compiletest_rs-devel and > rust-nickel+unstable-devel) cannot. Attempting to install them leads to > this: > > Error: > Problem 1: conflicting requests > - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with > crate(compiletest_rs/default) < 0.4.0) needed by > rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch > Problem 2: conflicting requests > - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with > crate(compiletest_rs/default) < 0.4.0) needed by > rust-nickel+unstable-devel-0.11.0-1.fc32.noarch > (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to > use not only best candidate packages) > > - All 4 packages contain this file: > > /usr/share/cargo/registry/nickel-0.11.0/Cargo.toml > > That is the only file in the 3 packages other than rust-nickel-devel. This is normal. These are optional packages for the optional dependencies. If the Rust SIG need them for another package, they will then be packaged. In the Cargo.toml, this is defined as follow: [dependencies.compiletest_rs] version = "0.3" optional = true > > - Some tests fail, but %check does not fail the build. Examples: > > running 75 tests > error: no matching package named `compiletest_rs` found > location searched: registry `https://github.com/rust-lang/crates.io-index` > required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` > test examples::chaining::expect_200::patch ... FAILED$<2> > test examples::chaining::expect_200::delete ... FAILED$<2> > test examples::chaining::expect_200::put ... FAILED$<2> > test examples::chaining::expect_404::get ... FAILED$<2> > test examples::chaining::expect_200::post ... FAILED$<2> > test examples::chaining::expect_200::root ... FAILED$<2> > test examples::chaining::expect_200::get ... FAILED$<2> > test examples::chaining::expect_404::patch ... FAILED$<2> > test examples::chaining::expect_404::post ... FAILED$<2> > test examples::chaining::expect_404::put ... FAILED$<2> > test examples::chaining::expect_404::root ... FAILED$<2> > test examples::chaining::expect_404::delete ... FAILED$<2> > error: no matching package named `compiletest_rs` found > location searched: registry `https://github.com/rust-lang/crates.io-index` > required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` > test examples::custom_error_handler::accepts_some_inputs ... FAILED$<2> > test examples::custom_error_handler::has_custom_message_for_fallthrough ... > FAILED$<2> > test examples::custom_error_handler::has_custom_message_for_custom_error ... > FAILED$<2> > > Same they need compiletest_rs. I have packaged it and made the tests run: https://copr.fedorainfracloud.org/coprs/build/1129155 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1783615 [Bug 1783615] Review Request: rust-compiletest_rs - Compiletest utility from the Rust compiler as a standalone testing harness -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
