https://bugzilla.redhat.com/show_bug.cgi?id=1766157 Stefan Hajnoczi <stefanha@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(crobinso@redhat.c | |om) --- Comment #9 from Stefan Hajnoczi <stefanha@xxxxxxxxxx> --- (In reply to Cole Robinson from comment #8) > Since %configure can't be used, I think you'll want to do > > %set_build_flags > ./configure ... > > That's what the %configure macro does essentially. See rpm --eval > "%configure" or the > macro definition in /usr/lib/rpm/macros > > Things flagged by fedora-review: > > * Use '%license COPYING' instead of %doc > > * The package ships .a static libraries. Are these required? If not they > should be removed. > I think typically ./configure scripts will have a way to opt in to > building these, but > just rm'ing them before %make_install is probably sufficient, or using > %exclude. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries > > * Source: should be the full URL format that URL: has. URL: should point to > the webpage for > the project, or git repo if it doesn't have one. > > * The devel package dep needs to be tweaked to: > Requires: %{name}%{?_isa} = %{version}-%{release} > > I think that's it Thanks for the feedback! I have updated the spec and rebuilt the RPMs. https://vmsplice.net/~stefan/liburing.spec https://vmsplice.net/~stefan/liburing-0.2-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
