[Bug 1771173] Review Request: xournalpp - Handwriting note-taking software with PDF annotation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1771173



--- Comment #9 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #8)
>  - Add a Requires: hicolor-icon-theme for owning the icons directory
> 
>  - You need to validate the desktop file too:
> 
> BuildRequires: desktop-file-utils
> 
> […]
> 
> desktop-file-validate
> %{buildroot}%{_datadir}/applications/com.github.%{name}.%{name}.desktop
> 

Fixed.



>  - Split %{_datadir}/%{name} into a separate noarch data subpackage and
> Requires it from the main package:
> 
> [!]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
>      Note: Arch-ed rpms have a total of 2099200 bytes in /usr/share
> 
> 
Split done for ui and plugisn.

Updated files
SPECS:
https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhide-x86_64/01128644-xournalpp/xournalpp.spec
SRPMS:
https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhide-x86_64/01128644-xournalpp/xournalpp-1.0.16-3.fc32.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux