[Bug 1782946] Review Request: xml-maven-plugin - Maven XML Plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1782946



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Thanks for the review!

>  - repo2.maven.org is returning Error 403 and pointing to repo1.maven.org :
> 
> Source0:      
> https://repo1.maven.org/maven2/org/codehaus/mojo/xml-maven-plugin/%{version}/
> xml-maven-plugin-%{version}-source-release.zip

Weird, but good catch. For building the SRPM, I just used the tarball from the
lookaside cache that was there from the retired package.

>  - LICENCE.txt must be installed with %license not %doc:
> 
> %files -f .mfiles
> %license LICENSE.txt
> %doc NOTICE.txt
> 
> %files javadoc -f .mfiles-javadoc
> %license LICENSE.txt
> %doc NOTICE.txt

I've changed NOTICE.txt to %license as well, since it contains the copyright
notice.

> Package approved. Please fix the aforementioned issues before import.

Fixed locally.

Releng ticket for package unretirement:

https://pagure.io/releng/issue/9102

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux