https://bugzilla.redhat.com/show_bug.cgi?id=1780823 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: rm -rf %buildroot %defattr(-,root,root) - Please use macro here: %{_includedir}/%{basen}/*.h - Please use librinutils as base package and add a -devel subpackage and add a Provides: librinutils-static = %{version}-%{release} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx