https://bugzilla.redhat.com/show_bug.cgi?id=1778325 --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Alessio from comment #2) > Thank you! > > (In reply to Robert-André Mauchin from comment #1) > > > > - Why -j 4? > > > > Mmm, isn't the build process more performant in that way? No the purpose of %make_build is to automatically determine the number of cpus via %{?_smp_mflags}. See how these macros are defined: make_build: %{__make} %{_make_output_sync} %{?_smp_mflags} %{_make_verbose} _smp_mflags: %([ -z "$RPM_BUILD_NCPUS" ] \ && RPM_BUILD_NCPUS="`/usr/bin/getconf _NPROCESSORS_ONLN`"; \ if [ "$RPM_BUILD_NCPUS" -gt 16 ]; then echo "-j16"; \ elif [ "$RPM_BUILD_NCPUS" -gt 3 ]; then echo "-j$RPM_BUILD_NCPUS"; \ else echo "-j3"; fi) (In reply to Alessio from comment #3) > (In reply to Robert-André Mauchin from comment #1) > > install -pm 0755 anonymize %{buildroot}%{_bindir}/dicomanonymize > > And what do you think about that? > The package (and git repository) is called DICOMAnonymizer, the compilation > process produce an executable called anonymize. It makes sense to name > "dicomanonymize" the command contained in the RPM, or it could be better > "dicomanonymizer"? It's ok. Use what you feel it's best for your users. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
