https://bugzilla.redhat.com/show_bug.cgi?id=1764175 --- Comment #8 from Alejandro Alvarez <a.alvarezayllon@xxxxxxxxx> --- Hello, Thanks for the review. New Spec URL: https://raw.githubusercontent.com/astrorama/copr/4c7b8a0a28c610c868d81365c5653caf7392e410/Elements/elements.spec New SRPM URL: https://dl.bintray.com/astrorama/archive/elements-5.8-4.fc31.src.rpm New Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39482346 > Use a better name for your archive: > Source0: https://github.com/degauden/Elements/archive/%{version}/%{name}-%{version}.tar.gz Done. > Use %global, not %define: Replaced %define by %global > I would simplify these: Done for makedir. However, for cmakedir I can't, since there is one file owned by the main rpm, and the rest by the devel one. I have got rid of the xmldir macro to make this more clear. > Own this directory: /usr/share/Elements Done > Fix the changelog entry: Done, my bad. While on it, I have also made the description more verbose to fix this warning: elements.src: W: description-shorter-than-summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
