https://bugzilla.redhat.com/show_bug.cgi?id=1767998 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use a better name for your archive: Source0: https://github.com/linux-on-mac/mbpfan/archive/v%{version}/%{name}-%{version}.tar.gz - Not ok: you need to build with Fedora's build flags: %build %set_build_flags %make_build - You need to add the SystemD scriptlets: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd BuildRequires: systemd-rpm-macros […] %post %systemd_post %{name}.service %preun %systemd_preun %{name}.service %postun %systemd_postun_with_restart %{name}.service - Remove the executable bits mbpfan.x86_64: W: spurious-executable-perm /usr/share/man/man8/mbpfan.8.gz you should specify mode with -m: %install # Installing the binary install -Dpm 0755 -t %{buildroot}%{_sbindir}/ bin/%{name} # Installing the systemd service install -Dpm 0644 -t %{buildroot}%{_unitdir}/ %{name}.service # Installing the configuration file install -Dpm 0644 -t %{buildroot}/etc/ %{name}.conf # Installing the manual install -Dpm 0644 -t %{buildroot}%{_mandir}/man8/ %{name}.8.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
