https://bugzilla.redhat.com/show_bug.cgi?id=1774098 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - License is not a valid shourthand, see list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses License: ASL 2.0 - Release start at 1 Release: 1 - Group: is not used in Fedora - BR should indicate the Python3 version, unversioned is forbidden: BuildRequires: python3-devel BuildRequires: python3-setuptools Requires: python3-atomiclong Requires: python3-fusepy Requires: python3-pygit2 Requires: python3-raven Requires: python3-pycparser - BuildRoot: is not used in Fedora - You should remove preexisting egginfo rm -rf gitfs.egg-info/ - python setup.py build → %py3_build - python setup.py install --prefix=%{_prefix} --root=%{buildroot} → %py3_install - %{buildroot}/var/lib/gitfs → %{buildroot}%{_sharedstatedir}/gitfs - Not needed: %defattr(-,root,root,-) - Should be python3 and globbing the entirety of %{python_sitelib}/ is forbidden, be more specific instead: %{python_sitelib}/gitfs/ - %changelog entries are not valid: * Tue Nov 19 2019 Vlad Temian <vladtemian@xxxxxxxxx> - 0.5.1-1 Please read the Guidelines and specifically the Python ones: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx