https://bugzilla.redhat.com/show_bug.cgi?id=1773344 Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fschwarz@xxxxxxxxxxxxxxxxx --- Comment #1 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- just a few random comments: - %license is empty - you should fetch Source0 from github releases (if you don't like the auto-generated archive file name, there is a way to change that) or document why this is not possible - I prefer using "%src_name" instead of "%pkg_name" because the former enables the use of "%%pypi_source" (not applicable for this package because it is not available on pypi but maybe we can get a bit more consistency for Python packages). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
