https://bugzilla.redhat.com/show_bug.cgi?id=1780906 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #3) > I thought the arch specific Provides would be better, but I've removed that > bit to please rpmlint. If it concerns you, you could include both. > Well, this isn't a general purpose library so we won't have tools linking to > it as they generally do. Only users that run simulations using Arbor will > link against it, and it is extremely unlikely that such simulation code will > ever be packaged in Fedora. Since this package is related to science and > correctness is paramount, I'm wary of providing any features that upstream > does not support. I'm hoping upstream will start supporting shared > libraries, and if/when they do, I can make them available. What do you think? Ah, okay, I did not understand how the libraries would be consumed. In that case, please stick with what upstream supports. > I've done this, but now I've had to disable tests completely to get the > build to pass. Until upstream fixes the issue we've reported, we can't > enable them. Yes, or you could disable just the failing test. Or patch time_event_span as_time_event_span to replace "&v[0]" with "v->data()" as upstream suggested. In any case, the spec file now meets all of the MUST requirements, so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
