https://bugzilla.redhat.com/show_bug.cgi?id=1780941 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. One or two issue to consider but you can tweak those before the import. XXX APPROVED XXX Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2426880 bytes in 253 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ^ Autogenerated: could be moved to a different sub-package, but I leave that up to you to decide. - Does it makes sense to add "conflict: meataxe" to ensure that both meataxe and sharedmeataxe modules are not activated together? ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sharedmeataxe-devel , sharedmeataxe-libs ^ This looks OK. The main and devel packages require -libs. [?]: Package functions as described. ^ Not tested this. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2580480 bytes in /usr/share ^ This is because of the doc files, pointed out above already. [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sharedmeataxe-1.0-1.fc32.x86_64.rpm sharedmeataxe-devel-1.0-1.fc32.x86_64.rpm sharedmeataxe-libs-1.0-1.fc32.x86_64.rpm sharedmeataxe-debuginfo-1.0-1.fc32.x86_64.rpm sharedmeataxe-debugsource-1.0-1.fc32.x86_64.rpm sharedmeataxe-1.0-1.fc32.src.rpm sharedmeataxe.x86_64: W: spelling-error %description -l en_US autotoolized -> automatized sharedmeataxe.x86_64: W: spelling-error %description -l en_US submodule -> sub module, sub-module, module sharedmeataxe.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso sharedmeataxe-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmtx.so.0.0.0 exit@GLIBC_2.2.5 sharedmeataxe.src: W: spelling-error %description -l en_US autotoolized -> automatized sharedmeataxe.src: W: spelling-error %description -l en_US submodule -> sub module, sub-module, module sharedmeataxe.src: W: spelling-error %description -l en_US zsp -> zap, esp, zip sharedmeataxe.src: W: spelling-error %description -l en_US zmu -> mu, emu, z mu sharedmeataxe.src: W: spelling-error %description -l en_US versa -> avers, verse, verso 6 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: sharedmeataxe-debuginfo-1.0-1.fc32.x86_64.rpm sharedmeataxe-libs-debuginfo-1.0-1.fc32.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sharedmeataxe-debugsource.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> sharedmeataxe.x86_64: W: spelling-error %description -l en_US autotoolized -> automatized sharedmeataxe.x86_64: W: spelling-error %description -l en_US submodule -> sub module, sub-module, module sharedmeataxe.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso sharedmeataxe.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> sharedmeataxe-libs.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> sharedmeataxe-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libmtx.so.0.0.0 exit@GLIBC_2.2.5 sharedmeataxe-libs-debuginfo.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> sharedmeataxe-debuginfo.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> sharedmeataxe-devel.x86_64: W: invalid-url URL: https://users.fmi.uni-jena.de/~king/SharedMeatAxe/ <urlopen error [Errno -2] Name or service not known> 6 packages and 0 specfiles checked; 0 errors, 10 warnings. Source checksums ---------------- http://users.minet.uni-jena.de/~king/SharedMeatAxe/shared_meataxe-1.0.tar.gz : CHECKSUM(SHA256) this package : e45b0dc325f841d5c160c1eb03daa6587506220ad6ee5823397b4bf2fbd8fdb9 CHECKSUM(SHA256) upstream package : e45b0dc325f841d5c160c1eb03daa6587506220ad6ee5823397b4bf2fbd8fdb9 Requires -------- sharedmeataxe (rpmlib, GLIBC filtered): environment(modules) libc.so.6()(64bit) libmtx.so.0()(64bit) rtld(GNU_HASH) sharedmeataxe-libs(x86-64) sharedmeataxe-devel (rpmlib, GLIBC filtered): libmtx.so.0()(64bit) sharedmeataxe-libs(x86-64) sharedmeataxe-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) sharedmeataxe-debuginfo (rpmlib, GLIBC filtered): sharedmeataxe-debugsource (rpmlib, GLIBC filtered): Provides -------- sharedmeataxe: sharedmeataxe sharedmeataxe(x86-64) sharedmeataxe-devel: sharedmeataxe-devel sharedmeataxe-devel(x86-64) sharedmeataxe-libs: libmtx.so.0()(64bit) sharedmeataxe-libs sharedmeataxe-libs(x86-64) sharedmeataxe-debuginfo: debuginfo(build-id) sharedmeataxe-debuginfo sharedmeataxe-debuginfo(x86-64) sharedmeataxe-debugsource: sharedmeataxe-debugsource sharedmeataxe-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1780941 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, PHP, Java, Haskell, SugarActivity, Perl, R, Ocaml, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
