Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hydrogen - Advanced drum machine https://bugzilla.redhat.com/show_bug.cgi?id=190040 ------- Additional Comments From lkundrak@xxxxxxxxxx 2007-10-08 11:44 EST ------- Much thanks for the comments! > - You currently pass LIBDIR=%{_libdir} to make but not to make install! > I couldn't test this at a 64 bit machine atm, but either you should use it in > both places or not all That is no longer needed, I just forgot it there. Makefiles use ${libdir} from autoconf and set -DLIBDIR for the ladspa plugins path via .pro files. > - Remove these obsolete or unneeded options when installing the .desktop file: > --add-category X-Fedora \ > --add-category AudioVideo \ > --add-category Application \ > - Add the following to remove the obsolete Application category that is in > upstreams .desktop file: > --remove-category Application \ > - Remove "MimeType=text/xml" from hydrogen.desktop, thats way too generic! > - Remove obsolete "Version=1.0" from hydrogen.desktop > - No longer run update-desktop-database from %post[un] now the .desktop file no > longer defines a MimeType > - Add the following Categories from: > http://standards.freedesktop.org/menu-spec/latest/apa.html : > Midi > - Add the following X-foo categories, to mathc what CCRMA has so that this > package will work with CCRMA's nested audio utilities menus: > X-Drumming X-MIDI X-Jack Changed the options to desktop-file-install, removed hydrogen-0.9.3-sound-category.patch patch. > - The update icon cache scriptlets should check the existence of > gtk-update-icon-cache before calling it, see: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda I've modified the scriptlets accordingly. Here's the new package: Spec URL: http://people.redhat.com/lkundrak/SPECS/hydrogen.spec SRPM URL: http://people.redhat.com/lkundrak/mock-results/hydrogen-0.9.3-9.fc8.i386/hydrogen-0.9.3-9.fc8.src.rpm The mock build results: http://people.redhat.com/lkundrak/mock-results/hydrogen-0.9.3-9.fc8.i386/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review