[Bug 1770566] Review Request: gron - Make JSON greppable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1770566



--- Comment #5 from Dusty Mabe <dustymabe@xxxxxxxxxx> ---
(In reply to Neal Gompa from comment #4)
> Have you considered using "go2rpm" to generate this spec file? It produces
> Go packaging that is compliant with current packaging guidelines?


wow! go2rpm is freaking awesome. Lars has been building this package in copr
for over
a year. I don't think go2rpm existed then.

Lars I just tried this out. Here is what I did: 


I installed go2rpm and ran it with using the following commands:

```
$ sudo dnf install /usr/bin/go2rpm
$ mkdir go2rpm && cd go2rpm
$ go2rpm github.com/tomnomnom/gron -v 0.6.0
```

That creates a `golang-github-tomnomnom-gron.spec` that can be used to build an
rpm. We probably
want to tweak it slighty to make a subpackage named `gron` so people can `dnf
install gron`. Here's
a diff I applied to get that:

```
@@ -29,6 +29,12 @@
 %description
 %{common_description}

+%package -n gron
+Summary:       %{summary}
+ 
+%description -n gron 
+%{common_description}
+
 %gopkg

 %prep
@@ -47,7 +53,7 @@
 %gocheck
 %endif

-%files
+%files -n gron
 %license LICENSE
 %doc docs CHANGELOG.mkd README.mkd
 %{_bindir}/*

```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux