[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1694366



--- Comment #21 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
Hello everyone!

I am not able to get the latest spec/srpm (getting a 404). Anyways, I had
written a spec as I was not aware of this request. Out of all the failing
tests, only one test fails as they only make sense when testing on a virtual
environment [0] (that test also requires pytest-env, not yet packaged for
Fedora). We can disable that test and proceed further on.

We would also need to apply some patches to fix the remaining of the failing
tests [1]-[2].

Other than that, here is my attempt at writing up a spec:
https://major.fedorapeople.org/python-pre-commit/python-pre-commit.spec
SRPM:
https://major.fedorapeople.org/python-pre-commit/python-pre-commit-1.20.0-1.fc31.src.rpm

The scratch build fails because I am not sure how to apply the patches for the
same. For now, I have added the patches/diffs in the same directory.

I will change the name of the package as discussed above.

[0]:
https://github.com/pre-commit/pre-commit/issues/1235#issuecomment-562868123
[1]: https://github.com/pre-commit/pre-commit/pull/1236
[2]: https://github.com/pre-commit/pre-commit/pull/1237

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux