https://bugzilla.redhat.com/show_bug.cgi?id=1770566 Dusty Mabe <dustymabe@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dustymabe@xxxxxxxxxx --- Comment #1 from Dusty Mabe <dustymabe@xxxxxxxxxx> --- Hi Lars, Thanks for contributing this back to Fedora! I'm not a sponsor (i'll work on trying to get us one) but I have done a review. I'll post the review in a followup comment. Before I post the review I think it's worth noting that our Golang package guidelines have now been published and are in the Fedora Documentation. I have to admit it's been a while since I looked at them myself and I'm impressed with how good it looks (lots of new macros to help packaging golang packages!). Some of the issues that are found in the review will probably be addressed if we update your spec to use the new macros. Here is a link to the go guideline documentation: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ Here is a link to a simple example for a binary package (like this one): https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_simple_binary_package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
