https://bugzilla.redhat.com/show_bug.cgi?id=1780849 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > # Turn off the brp-python-bytecompile script 1. why is this neeeded 2. there is a newer way to do this described at https://docs.fedoraproject.org/en-US/packaging-guidelines/#_brp_buildroot_policy_scripts > License: MIT and BSD and ZPLv2.0 and Bitstream Vera and OFL This needs an explanation in comment. > Patch0: pymol-setup.py.patch > Patch1: pymol-wmclass-main.patch > Patch2: pymol-wmclass-pmgapp.patch > Patch3: pymol-mmtf.patch So do those. > # Fix shebang in individual files to ensure Python 3 dependence > sed -i '1s=^#!/usr/bin/\(python\|env python\)[0-9.]*=#!%{__python3}=' test/cyg test/run test/show Consider using pathfix.py from python3-devel. > echo "%{__python3} %{python3_sitearch}/pymol/__init__.py \"\$@\"" >> pymol Consider using `exec` here. > %{python3_sitearch}/*.egg-info Consider adding trailing slash to ensure this remains a directory (if it is a directory). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
