[Bug 1757675] Review Request: calls - Phone dialer and call handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1757675



--- Comment #8 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Lubomir Rintel from comment #6)
> (In reply to Robert-André Mauchin from comment #5)
> > (In reply to Lubomir Rintel from comment #4)
> > > (In reply to Robert-André Mauchin from comment #3)
> > > >  - Don't own %{_datadir}/icons/hicolor, instead Requires: hicolor-icon-theme
> > > > and be more specific:
> > > > 
> > > > Requires: hicolor-icon-theme
> > > > 
> > > > […]
> > > > 
> > > > %{_datadir}/icons/hicolor/*/apps/*.svg
> > > 
> > > I don't think this is necessary. calls app doesn't require anything that
> > > hicolor-icon-theme package ships and will do just fine without it.
> > > 
> > 
> > This is necessary, you don't own a directory already owned by another
> > package, you depend on it.
> 
> I have to respectfully disagree.
> 
> The directory is not owned just by the hicolor-icon-theme package It happens
> to need it in place and so do I. RPM allows two packages to ship the same
> directory specifically for this. This is a common practice.
> 
> That is also what the packaging guidelines suggest:
> 
>   Please also note that it is not uncommon for multiple packages to provide
> the same directory. [1]
> 
> [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_file_and_directory_dependencies

The common practice is to depend on hicolor-icon-theme.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux