Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rats - Rough Auditing Tool for Security https://bugzilla.redhat.com/show_bug.cgi?id=317101 ------- Additional Comments From lkundrak@xxxxxxxxxx 2007-10-08 09:49 EST ------- I can not compare the upstream version with the packaged at the time as the upstream web is not responding at the time. The patch rats-2.1-linux.diff doesn't seem right to me; 1.) files rats-2.1/lex.yy*.c are autogenerated. Why don't you regenerate them instead of patching? 2.) You seem to be patching unrelated issues in this one patch. Please eplit it into multiple patches. When I was talking about libdir in comment #2 and comment #3, I did not notice that the package doesn't make use of libdir. Please ingore it. Another bad thing in .SPEC: 8 URL: http://www.securesw.com/rats/rats-%{version}.tar.gz 9 Source0: rats-2.1.tar.gz The URL tag is for the web page of the software's author, Source0 is for URIs of the files. It should look like this instead: 8 URL: http://www.securesw.com/rats/ 9 Source0: http://www.securesw.com/rats/rats-%{version}.tar.gz Apart from these issues, the package meets the Packing Guidelines, and I will approve it when the issues are resolved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review