Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: astromenace - Hardcore 3D space shooter with spaceship upgrade possibilities https://bugzilla.redhat.com/show_bug.cgi?id=313461 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-10-08 09:31 EST ------- Full review done (sources match upstream, license ok, everything else ok), a couple of Should Fix's, but no blockers, so its approved! Should Fix: -Please always start the Name with a capital in the .desktop file, so: Name=Astromenace -Please use opengl-games-utils wrapper to check for missing DRI Add: "Requires: opengl-games-utils" Add to %install: "ln -s opengl-game-wrapper.sh $RPM_BUILD_ROOT%{_bindir}/%{name}-wrapper" Add "%{_bindir}/%{name}-wrapper" to files Change the .desktop file Exec entry from "%{name}" to "%{name}-wrapper" -Once build please add this to the games-live .ks file: http://fedoraproject.org/wiki/SIGs/Games/GamesLive -Please change the default resolution to 640x480 (it defaulted to my desktop resolution). With my desktop resolution its unplayable with my somewhat under powered 3d card (intel 965) on 640x480 it rocks on at 15 fps! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review