https://bugzilla.redhat.com/show_bug.cgi?id=1765730 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. A few comments, but no blockers. Worth a look before import. XXX APPROVED XXX - I've not been able to find any source files that say GPLv2+. The GPLv2 license file is included. Could you double check where they say GPLv2 "or newer" just to be sure that the "+" is needed please? - incorrect-fsf-address /usr/share/licenses/gap-pkg-grpconst/LICENSE: Please let upstream know about this. - Do the Requires need to be versioned? The package's web page says: * autpgrp >=1.6 * irredsol >=1.2 Versioning them may help catch issues later when individual packages are updated. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. ^ I've not been able to find any source files that say GPLv2+. The GPLv2 license file is included. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. ^ Not tested this out. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-grpconst-2.6.1-1.fc32.noarch.rpm gap-pkg-grpconst-doc-2.6.1-1.fc32.noarch.rpm gap-pkg-grpconst-2.6.1-1.fc32.src.rpm gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US isomorphism -> isomorphic, metamorphism, sophism gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US nilpotent -> nil potent, nil-potent, omnipotent gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US supersolvable -> super solvable, super-solvable, insuperable gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US nonsoluble -> non soluble, non-soluble, insoluble gap-pkg-grpconst.noarch: W: only-non-binary-in-usr-lib gap-pkg-grpconst.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-grpconst/LICENSE ^ Please let upstream know about this. gap-pkg-grpconst-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-grpconst-doc.noarch: W: no-documentation gap-pkg-grpconst.src: W: spelling-error %description -l en_US isomorphism -> isomorphic, metamorphism, sophism gap-pkg-grpconst.src: W: spelling-error %description -l en_US nilpotent -> nil potent, nil-potent, omnipotent gap-pkg-grpconst.src: W: spelling-error %description -l en_US supersolvable -> super solvable, super-solvable, insuperable gap-pkg-grpconst.src: W: spelling-error %description -l en_US nonsoluble -> non soluble, non-soluble, insoluble 3 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). gap-pkg-grpconst-doc.noarch: W: invalid-url URL: https://gap-packages.github.io/grpconst/ <urlopen error [Errno -2] Name or service not known> ^ False positive. gap-pkg-grpconst-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-grpconst-doc.noarch: W: no-documentation gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US isomorphism -> isomorphic, metamorphism, sophism gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US nilpotent -> nil potent, nil-potent, omnipotent gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US supersolvable -> super solvable, super-solvable, insuperable gap-pkg-grpconst.noarch: W: spelling-error %description -l en_US nonsoluble -> non soluble, non-soluble, insoluble gap-pkg-grpconst.noarch: W: invalid-url URL: https://gap-packages.github.io/grpconst/ <urlopen error [Errno -2] Name or service not known> gap-pkg-grpconst.noarch: W: only-non-binary-in-usr-lib gap-pkg-grpconst.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-grpconst/LICENSE 2 packages and 0 specfiles checked; 1 errors, 9 warnings. Source checksums ---------------- https://github.com/gap-packages/grpconst/releases/download/v2.6.1/grpconst-2.6.1.tar.gz : CHECKSUM(SHA256) this package : c52eaace9be2bb71f0a6f9be886080dcb9dc08ab89c4a2ad9c67afab8810b0c9 CHECKSUM(SHA256) upstream package : c52eaace9be2bb71f0a6f9be886080dcb9dc08ab89c4a2ad9c67afab8810b0c9 Requires -------- gap-pkg-grpconst (rpmlib, GLIBC filtered): gap-pkg-autpgrp gap-pkg-irredsol gap-pkg-grpconst-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-grpconst Provides -------- gap-pkg-grpconst: gap-pkg-grpconst gap-pkg-grpconst-doc: gap-pkg-grpconst-doc Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1765730 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api Disabled plugins: Haskell, fonts, Ocaml, R, Java, C/C++, Python, PHP, Perl, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
