https://bugzilla.redhat.com/show_bug.cgi?id=1780297 --- Comment #2 from Philip Matura <pfed@xxxxxxxxxxxx> --- (In reply to Jerry James from comment #1) > Note that "BuildRequires: jack-audio-connection-kit-devel" should be > replaced with "BuildRequires: pkgconfig(jack)". See > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > PkgConfigBuildRequires/. I read that as "use pkgconfig(foo) if the package actually uses pkg-config to locate the dependency", which this one here does not. Should I use it anyway - as general rule - if the dependency provides it? > Have you done any reviews or submitted any pull requests? (See steps 2.2 > and 2.3 of > https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.) No. I'll try to look into some tickets. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
