https://bugzilla.redhat.com/show_bug.cgi?id=1773300 Michael Kuhn <suraia@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #2 from Michael Kuhn <suraia@xxxxxxxxx> --- (In reply to Ondřej Pohořelský from comment #1) > This is informal review only. I would appreciate any feedback. > > I don't see any problem, except not using "make %{?_smp_mflags}" macro. > However this is only SHOULD, not must. Thank you for your review! "%{?_smp_mflags}" should not make any difference since the Makefile simply concatenates a few source files. I can still add it, of course. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
