https://bugzilla.redhat.com/show_bug.cgi?id=1780369 --- Comment #1 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- Needs a few minor things fixed up before I can approve it: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 >From the packaging guildelines: Packagers SHOULD NOT simply glob everything under the sitelib or sitearch directories. The following SHOULD NOT be used: %{python3_sitelib}/* %{python3_sitearch}/* %{python_sitelib}/* %{python_sitearch}/* And packages MUST NOT include the top-level __pycache__ directory (see below). ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.8/site- packages/zezere(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site-packages/zezere-0.1-py3.8.egg-info(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site- packages/zezere/__pycache__(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site-packages/zezere/migrations(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site- packages/zezere/migrations/__pycache__(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site- packages/zezere/templatetags(set, C, Failed, defaulting, locale,, to), /usr/lib/python3.8/site-packages/zezere/templatetags/__pycache__(set, C, Failed, defaulting, locale,, to), /usr/share/licenses/zezere(set, C, Failed, defaulting, locale,, to) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Installation errors ------------------- INFO: mock.py version 1.4.21 starting (python version = 3.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.21 INFO: Mock Version: 1.4.21 Finish: chroot init INFO: installing package(s): /home/jsmith/Documents/Fedora/Reviews/1780369-zezere/results/zezere-0.1-1.fc32.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/jsmith/Documents/Fedora/Reviews/1780369-zezere/results/zezere-0.1-1.fc32.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: zezere-0.1-1.fc32.noarch.rpm zezere-0.1-1.fc32.src.rpm zezere.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/fedora-iot/zezere/archive/v0.1.tar.gz#/zezere-0.1.tar.gz : CHECKSUM(SHA256) this package : c1a31b9e5bdf0d4f2f865cbb34776f3369e8a7df3dbd714f1687d12560b340c9 CHECKSUM(SHA256) upstream package : c1a31b9e5bdf0d4f2f865cbb34776f3369e8a7df3dbd714f1687d12560b340c9 Requires -------- zezere (rpmlib, GLIBC filtered): python(abi) python3.8dist(django) python3.8dist(django-ipware) python3.8dist(djangorestframework) python3.8dist(gunicorn) python3.8dist(mozilla-django-oidc) python3.8dist(psycopg2) python3.8dist(requests) python3.8dist(rules) Provides -------- zezere: python3.8dist(zezere) python3dist(zezere) zezere Diff spec file in url and in SRPM --------------------------------- --- /home/jsmith/Documents/Fedora/Reviews/1780369-zezere/srpm/zezere.spec 2019-12-05 15:56:10.644439187 -0500 +++ /home/jsmith/Documents/Fedora/Reviews/1780369-zezere/srpm-unpacked/zezere.spec 2019-12-05 14:14:34.000000000 -0500 @@ -2,5 +2,5 @@ Version: 0.1 Release: 1%{?dist} -Summary: A provisioning service for Fedora IoT +Summary: A provisioning server for Fedora IoT License: MIT URL: https://github.com/fedora-iot/zezere @@ -13,5 +13,5 @@ %description -Zezere is a provisioning service for Fedora IoT. It can be used for deploying +Zezere is a provisioning server for Fedora IoT. It can be used for deploying Fedora IoT to devices without needing a physical console. Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1780369 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, Generic, Python Disabled plugins: Perl, PHP, Ocaml, Java, SugarActivity, Haskell, R, C/C++, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
