https://bugzilla.redhat.com/show_bug.cgi?id=1779404 --- Comment #7 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- (In reply to Jun Aruga from comment #5) > > Spec URL: https://leigh123linux.fedorapeople.org/pub/review/rubygem-hrx/rubygem-hrx.spec > > > # Move the tests into place > > ln -s %{_builddir}/spec spec > > You can remove the 2 lines, as the Source0 (= hrx-1.0.0.gem) includes > `spec/*_spec.rb files` in it. > The "spec" exists there without doing "ln -s ...". > > Maybe the lines came from following examples I introduced you. > In the examples the each Source0 does not have the unit test files in it (= > the gem file). > That's the reason why the lines were needed. > https://src.fedoraproject.org/rpms/rubygem-listen/blob/master/f/rubygem- > listen.spec > https://src.fedoraproject.org/rpms/rubygem-rake/blob/master/f/rubygem-rake. > spec > > > > rspec -rspec_helper spec > > You do not need to add "-rspec_helper", as it is correctly required from > each `*_spec.rb` file. > > Referring the Ruby guideline, you can just replace it with "rspec -Ilib > spec". > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_rspec > > > dot files. > > I think that the dot files are for only development use like `.gitignore` as > well. > Possibly you can change like this. > > ``` > %files > %dir %{gem_instdir} > -%exclude %{gem_instdir}/.gitignore > +%exclude %{gem_instdir}/.* > %license %{gem_instdir}/LICENSE > %{gem_libdir} > %exclude %{gem_cache} > @@ -64,8 +62,6 @@ popd > > %files doc > %doc %{gem_docdir} > -%doc %{gem_instdir}/.rdoc_options > -%exclude %{gem_instdir}/.rspec > %doc %{gem_instdir}/CONTRIBUTING.md > %{gem_instdir}/Gemfile > %doc %{gem_instdir}/README.md > ``` Spec file and srpm updated with recommended review changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
