[Bug 1773467] Review Request: avocado-vt - A avocado plugin for virtualization related tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1773467

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx



--- Comment #9 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
When you have scripts with shebangs copied onto guest VM instances there are
several options, sorted "the best first" based on my opinion:


 1. create the shebangs upon copying, based on some settings about the VM or
other options
 2. keep the files in the package as nonexecutables, add the executable bit
after copying
 3. disable the shebangs check/mangling for certain files, but be very verbose
about what's going on in the comment - the current comment is not clear enough
on why nor it makes any sense to me


----------------


This is forbidden, pygobject2 is Python 2:

   Requires: pygobject2


----------------


This is unnecessary: Requires: python3

And this is suspicious:  Requires: python3-devel


----------------


This is outdated:  %{__python3} setup.py build  -> use %py3_build instead
                   %{__python3} setup.py install --root %{buildroot}
--skip-build  -> use %py3_install instead

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux