https://bugzilla.redhat.com/show_bug.cgi?id=1770582 --- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review, Jerry. Sorry for the delay. (In reply to Jerry James from comment #3) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > 1. Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/java/jLEMS > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files > > Remove %dir %{_javadir}/%{name} from %files to fix this. It is included > in > .mfiles. Fixed. > > 2. $ lems 1 2 3 4 > Running the LEMS application... > Error: Could not find or load main class org.lemsml.jlems.viz.VizMain > > Perhaps CLASSPATH should be set to %{_javadir}/%{name}/jlems.jar in > %{_bindir}/lems? Fixed. > > 3. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > #_case_sensitivity > Does the package name need to contain uppercase letters? LEMS is an acronym, so yes, I'd like to keep it in uppercase. The python package is also similarly uppercase: https://src.fedoraproject.org/rpms/python-PyLEMS > > 4. These two manual dependencies: > > Requires: java-headless > Requires: javapackages-filesystem > > are generated automatically, so do not need to be in the spec file. Removed. > > 5. The tests are not run. Can you add a %check script to do so? FIXED: Maven tests enabled, and examples run as additional tests too. Spec URL: https://ankursinha.fedorapeople.org/jLEMS/jLEMS.spec SRPM URL: https://ankursinha.fedorapeople.org/jLEMS/jLEMS-0.9.9.1-2.fc32.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
