https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #3 from Till Hofmann <thofmann@xxxxxxxxxxxxxxxxx> --- Some minor comments: * Version should just be 0: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstream_has_never_chosen_a_version * Please include the date in the release field: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots. It should be something like 1.20191122.c4066aa * Is %{url}/tarball a new feature of GitHub? I've never seen it before. Usually, the guidelines recommend a slightly different URL. I'd definitely recommend using the full commit hash and then define the shortcommit using the full commit hash: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services * The version in the changelog does not match the release tag. Easiest way to do this is to remove all changelog entries, set Release to 0.20191122.c4066aa (0 at the start), and then use `rpmdev-bumpspec` to bump the release and generate the changelog entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
