Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Creole - A database abstraction layer for PHP5 https://bugzilla.redhat.com/show_bug.cgi?id=256521 fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxx 2007-10-08 01:24 EST ------- REVIEW: * rpmlint : W: no-documentation * The package is named according to the Package Naming Guidelines. * The spec file name match the base package * The package meet the PHP Packaging Guidelines (see below) * Fedora approved license (LGPLv2) * License field in the package spec file match the actual license * The spec file is written in American English * The spec file is legible * The sources used to build the package must match the upstream source 87480d20b83be9ae859153539ec57c70 creole-1.1.0.tgz * build in mock (F-7, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * no documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane* * Final Provides ok php-pear(pear.phpdb.org/creole) = 1.1.0 php-pear-creole = 1.1.0-5.fc8 * Final Requires /usr/bin/pear php-channel(pear.phpdb.org) php-cli >= 5.0.0 php-pear ** No test suite or example to run. There is actually no PHP Guidelines for non standard channel, but this spec conforms with other RPM. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review